Have global_norm properly handle when input consists of only None#1832
Merged
QuantuMope merged 1 commit intopytorchfrom Mar 27, 2026
Merged
Have global_norm properly handle when input consists of only None#1832QuantuMope merged 1 commit intopytorchfrom
QuantuMope merged 1 commit intopytorchfrom
Conversation
emailweixu
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global_normcan handle if the input has at least one non-None tensor but will crash if the input arg consists of only Nones. This fix handles the later case.