Skip to content

feat: add historical verification records#146

Open
AlphaMaleBaDI wants to merge 1 commit into
HubDApp:mainfrom
AlphaMaleBaDI:feature/historical-verification-records
Open

feat: add historical verification records#146
AlphaMaleBaDI wants to merge 1 commit into
HubDApp:mainfrom
AlphaMaleBaDI:feature/historical-verification-records

Conversation

@AlphaMaleBaDI
Copy link
Copy Markdown

Closes #133

Description

This PR transitions the verification registry from a destructive overwrite model to an auditable history model while preserving backward compatibility.

Changes

  • Added globally unique verification request IDs via NextVerificationRequestId
  • Added historical verification storage via VerificationRecord(request_id)
  • Added project verification history tracking via ProjectVerificationHistory(project_id)
  • Preserved existing Verification(project_id) storage path for backward compatibility and O(1) current-record lookups
  • Updated verification lifecycle operations (request, approve, reject, revoke) to synchronize both current and historical records
  • Added get_verification_history(project_id) API for historical retrieval
  • Updated verification_exists to inspect project history presence
  • Extended TTL management to include current records, history vectors, and historical verification entries
  • Added ordering and uniqueness tests covering multiple verification requests and cross-project request ID generation

Acceptance Criteria Coverage

  • Each verification request receives a unique request ID
  • Project stores current verification separately from history
  • APIs can fetch current and historical verification records
  • Tests cover multiple requests and history ordering

Notes

Local Rust test execution was blocked by a missing MSVC linker (link.exe) in the current environment. The implementation was validated through storage-path verification, state-transition analysis, compatibility review, and dedicated test additions. CI will provide the authoritative build and test verification.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 1, 2026

@AlphaMaleBaDI Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Historical Verification Records

1 participant