fix: resolve state command parsing, ordering, and edge cases#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Overview
this fixes several bugs with the
gitgo statecommand. the parser now handles aliases correctly, the display order is fixed to show chronological order, and some missing guards and edge cases are now covered.Changes
gitgo state: fixed argparse rejecting short-form aliases like-land-s.gitgo state list: fixed states displaying in reverse chronological order. they now print oldest to newest with 1, 2, 3 numbering.gitgo state: patched a crash that happened when git outputs dates instead of indices for stash refs.gitgo state load: added a guard to prevent loading when no states exist.gitgo state: added validation to reject conflicting inputs likegitgo state list -s.gitgo state delete: locked the-aand--allflags strictly to the delete action so they aren't accepted elsewhere.How to Test
pip install -e ".[dev]"gitgo state save 'test state'and thengitgo state list.pytest tests/Checklist
CHANGELOG.mdunder the[Unreleased]sectionREADME.md(if I added or changed a command)