fix: resolve unconditional fall-through bugs across core commands#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Overview
Fixed a bunch of control-flow bugs found during the audit. The main issue was commands running downstream steps (like
git add .) unconditionally even when the parent step was skipped or failed.Changes
gitgo link: split into two explicit paths so we don't accidentally rungit add .on existing repos with unwanted files.gitgo push --select: added a skip_staging flag so it actually respects your interactive selection instead of committing everything anyway.gitgo user login: added proper error raising for bad emails and missingssh-keygeninstead of just crashing.gitgo user logout: inverted the order so we try to delete files first. this stops your git config from being wiped if the file deletion fails.gitgo jump: wrapped the pull command in an else block so it stops trying to pull from main when you just created a brand new local branch.How to Test
pip install -e ".[dev]"gitgo push --selectand pick a few files. Verify that only those files got committed.gitgo jump new-test-branch. Verify it checks out the branch without hanging to pull updates.Checklist
CHANGELOG.mdunder the[Unreleased]sectionREADME.md(if I added or changed a command)