Refactor/major internal organisation#48
Merged
Merged
Conversation
added 4 commits
April 8, 2026 23:56
everytime we change something in the adapter there are large constructor changes, the current architecture means that developers only have one point of extension and that is the mapper. solving bot problems by giving the adapter orchastration methods and more options to override, then cahnge all base adapter types to be modules that are included this is seen in how we minified groq code. though its "file" thing will be removed when we sanitize based on what a model supports
billybonks
force-pushed
the
refactor/major-internal-organisation
branch
from
6d0d440 to
a9b8eff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update names of classes to match reality
open_ai -openai and claude -> anthropic. claude code stays the same since that is the target
major internal rework of adapter
everytime we change something in the adapter there are large constructor
changes, the current architecture means that developers only have one point of
extension and that is the mapper.
solving bot problems by giving the adapter orchastration methods and more options
to override, then cahnge all base adapter types to be modules that are included
this is seen in how we minified groq code. though its "file" thing will be
removed when we sanitize based on what a model supports
colocated live tests
run live test
bundle exec ruby -Itest -e "Dir['test/**/*_test.rb'].sort.grep(%r{\Atest/integration/live/}).each { |f| require File.expand_path(f) }"run other tests
bundle exec ruby -Itest -e "Dir['test/**/*_test.rb'].sort.grep_v(%r{\Atest/integration/live/}).each { |f| require File.expand_path(f) }"