Skip to content

feat: disable env variables and add list endpoint#1

Open
maximka76667 wants to merge 1 commit intomainfrom
list-endpoint
Open

feat: disable env variables and add list endpoint#1
maximka76667 wants to merge 1 commit intomainfrom
list-endpoint

Conversation

@maximka76667
Copy link
Copy Markdown

@maximka76667 maximka76667 commented Mar 4, 2026

  • I added an endpoint to return a list of available artifacts. I tried to follow the same practices as the original code.
  • Also I disabled env variables for now and replaced them with some string literals
  • Also I modified upload endpoint to include id of uploaded file in the return type

@maximka76667 maximka76667 requested a review from vasyl-ks March 4, 2026 11:51
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding password and secret is really bad. Regardless I suggest an easier method for authentication, will discuss at the meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants