Text edition should have a clear exit option (see #371)#434
Conversation
Samellaperes
force-pushed
the
improvement-371
branch
from
d4e4442 to
7f62ca6
Compare
|
Comme nous n'avons pas eu besoin de modifier le scénario, aucune modification n'étais nécessaire au niveau des tests. Donc nous avons eu uniquement a modifier le editable.js pour rajouter un bouton. Aucune autre fonctionnalité n'a eu besoin d'être modifier. |
benel
changed the title
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
Thank you @Samellaperes and @othmaneutt for your contribution.
Here are a few changes to bring to your files.
| <button | ||
| type="button" | ||
| className="btn btn-success btn-sm mt-1" | ||
| onMouseDown={handleBlur} |
There was a problem hiding this comment.
By firing up this event, handleBlur got invoked twice.
This generates a conflict when you edit and save several times in a row.
benel
force-pushed
the
main
branch
3 times, most recently
from
69f00a6 to
5c4b1c8
Compare
Samellaperes
force-pushed
the
improvement-371
branch
3 times, most recently
from
9341d11 to
cacd5ac
Compare
Samellaperes
left a comment
Samellaperes
left a comment
There was a problem hiding this comment.
corrections done
Co-authored-by: Othmane Houasli <othmane.houasli@utt.fr> Co-authored-by: Vanelle Fotso <vanellefotso21@gmail.com>
|
Thank you for your contribution @Samellaperes @othmaneutt @vanellefotso21-crypto. Your contribution is live on the production server! Well done 🎉 |
2 participants
We, Samella LEUKOUO, FOTSO Vanelle, Othmane Houasli, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.