Filter provider admins from user list (for all but superadmins)#83
Merged
simon-20 merged 4 commits intoMay 11, 2026
Merged
Conversation
Previously anyone logged in as a PROVIDER_ADMIN saw in the list of a reporting org's users all the other provider admins for that org, but for now this is being removed until we have per-tool handling.
This commit hides provider admins from the list of users returned for reporting orgs for all except superadmins.
Filter provider admins from a reporting org's user list for other provider admins (still viewable by superadmins).
simon-20
force-pushed
the
sk-filter-provider-admins-reporting-org-endpoint
branch
from
fa29e91 to
89068e7
Compare
simon-20
changed the title
chrisarridge
approved these changes
May 11, 2026
Base automatically changed from
sk-fix-editor-permissions--upgrade-libsuitecrm
to
develop
May 11, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is compared against the
sk-fix-editor-permissions...branch, so need to wait until that is merged then rebase, before merging this.This PR fixes
/reporting-org/{ID}/usersso that it doesn't return the list of provider admins when logged in as a provider admin (super admins still see a user list which includes provider admins).This resolves #80