Skip to content

Issue 47#141

Open
anna-riesch wants to merge 20 commits into
masterfrom
issue-47
Open

Issue 47#141
anna-riesch wants to merge 20 commits into
masterfrom
issue-47

Conversation

@anna-riesch
Copy link
Copy Markdown
Contributor

Providing a config file to set and store gWhisper cli parameter values

Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>
@anna-riesch anna-riesch marked this pull request as ready for review August 29, 2022 10:32
Comment thread src/CMakeLists.txt
target_link_libraries ( ${TARGET_NAME}
PRIVATE
reflection
protoDoc
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think none of those linked libs are needed

protoDoc
)
target_link_libraries ( ${TARGET_NAME}
PUBLIC
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only last two deps needed?

Comment thread src/gWhisperSetting/CMakeLists.txt Outdated
Comment thread src/gWhisperSetting/GWhisperSetting.cpp Outdated
return setting;
}

// Ersetze ParseTree beim Suchen -> f_parseTree.findFirstChild
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

german comment

Comment thread src/gWhisperSetting/GWhisperSetting.cpp Outdated
Comment thread src/libCli/Call.cpp Outdated
Comment thread src/libCli/Call.cpp Outdated
Comment thread src/libLocalDescriptorCache/DescDbProxy.cpp Outdated
Comment thread testfile.json
@@ -0,0 +1,13 @@
{
"configParameter": {
"Ssl": null,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why "Ssl": null here?

Signed-off-by: Anna Riesch <Anna.Riesch@ibm.com>

}

void gWhisperSettings::retrieveConfigParameters(json &f_startElement){
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not used anymore

std::string findParameterSettingInConfig(const std::string &f_parameter, const json &f_startLayer);

json m_config;
std::vector<std::string> m_configParameters;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support configuration files - At least for output formatting options (colors)

2 participants