Add ROCTX support.#3
Open
sfantao wants to merge 3 commits into
Open
Conversation
Author
|
@walkup, any comments on this PR? |
Member
|
Sorry for the delay. I plan to check it out in the next few days but have been rather tied up.
…________________________________
From: Samuel F Antao ***@***.***>
Sent: Tuesday, April 26, 2022 10:57 AM
To: IBM/mpitrace ***@***.***>
Cc: Bob Walkup ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [IBM/mpitrace] Add ROCTX support. (PR #3)
@walkup, any comments on this PR? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
@walkup<https://github.com/walkup>, any comments on this PR?
—
Reply to this email directly, view it on GitHub<#3 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAWJMVA3KSMWBVSCO3QQWMLVG774LANCNFSM5T3R7PCA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Author
|
@walkup, did you manage to find the time to look at this one? |
Member
|
Sorry for the delays. I am travelling with limited network access for another week, and I don't have access to my git keys right now. My group at Yorktown recently jumped into AI performance issues, and that has required a lot of time and effort. I have complete confidence in your work and will take care of this when I return.
On a related subject, it has been brought to my attention that current wrappers do not cover Fortran 2008 MPI routines that "use mpi_2008". This subject appears to be quite troublesome because all MPI routines are name-shifted and different approaches are required for different MPI implementations (MPICH vs. OpenMPI), and the intercept libraries will end up depending on the Fortran compiler. And then there is MPI-4, with a lot of new routines to cover. At some point I need to address these gaps, but I am putting that off for a while.
Regards,
Bob Walkup ***@***.***)
…________________________________
From: Samuel F Antao ***@***.***>
Sent: Wednesday, June 22, 2022 11:28 AM
To: IBM/mpitrace ***@***.***>
Cc: Bob Walkup ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [IBM/mpitrace] Add ROCTX support. (PR #3)
@walkup, did you manage to find the time to look at this one? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: <IBM/mpitrace/pull/3/c1163262542@
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
@walkup<https://github.com/walkup>, did you manage to find the time to look at this one?
—
Reply to this email directly, view it on GitHub<#3 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAWJMVGWIUZXDYDOOUCWRATVQMWLLANCNFSM5T3R7PCA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
I applied the patch. Thanks for the contribution.
…________________________________
From: Bob Walkup ***@***.***>
Sent: Thursday, June 23, 2022 8:45 AM
To: IBM/mpitrace ***@***.***>
Subject: Re: [EXTERNAL] Re: [IBM/mpitrace] Add ROCTX support. (PR #3)
Sorry for the delays. I am travelling with limited network access for another week, and I don't have access to my git keys right now. My group at Yorktown recently jumped into AI performance issues, and that has required a lot of time and effort. I have complete confidence in your work and will take care of this when I return.
On a related subject, it has been brought to my attention that current wrappers do not cover Fortran 2008 MPI routines that "use mpi_2008". This subject appears to be quite troublesome because all MPI routines are name-shifted and different approaches are required for different MPI implementations (MPICH vs. OpenMPI), and the intercept libraries will end up depending on the Fortran compiler. And then there is MPI-4, with a lot of new routines to cover. At some point I need to address these gaps, but I am putting that off for a while.
Regards,
Bob Walkup ***@***.***)
________________________________
From: Samuel F Antao ***@***.***>
Sent: Wednesday, June 22, 2022 11:28 AM
To: IBM/mpitrace ***@***.***>
Cc: Bob Walkup ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [IBM/mpitrace] Add ROCTX support. (PR #3)
@walkup, did you manage to find the time to look at this one? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: <IBM/mpitrace/pull/3/c1163262542@
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
@walkup<https://github.com/walkup>, did you manage to find the time to look at this one?
—
Reply to this email directly, view it on GitHub<#3 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAWJMVGWIUZXDYDOOUCWRATVQMWLLANCNFSM5T3R7PCA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for ROCm markers by leveraging the roctx libraries. It creates a new folder parallel to nvtx and updates the common parts with "USE_ROCTX" guard and adapt the respective documentation.