Improve error handling when fetching CL command documentation#63
Merged
Conversation
Signed-off-by: venky225 <kona.venkatareddy@gmail.com>
Member
|
@Mohammed-Yaseen-Ali-2081 Have you reviewed this PR by chance? |
Mohammed-Yaseen-Ali-2081
previously approved these changes
Jun 8, 2026
Mohammed-Yaseen-Ali-2081
left a comment
Mohammed-Yaseen-Ali-2081
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, works as expected
Collaborator
|
@SanjulaGanepola Please merge this if you dont have any suggestions, Thanks |
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
SanjulaGanepola
changed the title
SanjulaGanepola
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SanjulaGanepola @Mohammed-Yaseen-Ali-2081
This PR is to catch the error message returned in GENCMDDOC, whereas earlier we are just returning if code ===0. Now we are throwing the error message.