Added main class and test for java lab1#7
Added main class and test for java lab1#7upkarlidder wants to merge 2 commits intoIBMDeveloperSF:masterfrom
Conversation
blumareks
left a comment
blumareks
left a comment
There was a problem hiding this comment.
@lidderupk I think we need to add quotes in both fields - at least this is what I get from Swift:
Activation ID:
fb8041e02b484c4a8041e02b48ac4a40
Results:
{
"message": "Hello World!"
}
Logs:
[]
- in addition there might be a timeout test condition of 60 seconds. So in other words if you send something and there is no response in 60 sec (or less) it means the service is down.
| } else { | ||
| result = "Hello " + nameArg.getAsString(); | ||
| } | ||
| response.addProperty("greeting", result); |
There was a problem hiding this comment.
@blumareks I do have quotes. I forgot to add in the comments :).
There was a problem hiding this comment.
|
Thanks @blumareks For |
|
@blumareks , can you please review and merge? Thank you 🙏 |
blumareks
left a comment
blumareks
left a comment
There was a problem hiding this comment.
reviewed - looks good!
|
@lidderupk I reviewed and accepted. Please merge. I do not have a button here for that... At least I do not see it. I know what it is. I do not have WRITE ACCESS: |
2 participants
@blumareks can you please review and let me know if I am missing any tests? I added the following
{ greeting: "Hello World!"}when called with empty args{ greeting: "Hello upkar!"}when called with{name: "upkar"}