Skip to content

[PW_SID:1055469] unit: Add better check for pkcs8_key_parser availability#488

Closed
IWDTestBot wants to merge 1 commit intoworkflowfrom
1055469
Closed

[PW_SID:1055469] unit: Add better check for pkcs8_key_parser availability#488
IWDTestBot wants to merge 1 commit intoworkflowfrom
1055469

Conversation

@IWDTestBot
Copy link
Copy Markdown
Owner

Check whether the pkcs8_key_parser kernel module is available (whether
built-in or as a module) before announcing that we support PKCS#8.

Note, this is an untested patch.

unit/test-eapol.c | 10 ++++++++++
1 file changed, 10 insertions(+)

Check whether the pkcs8_key_parser kernel module is available (whether
built-in or as a module) before announcing that we support PKCS#8.
@IWDTestBot
Copy link
Copy Markdown
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.14 seconds
Result: PASS

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 25.34 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 46.56 seconds
Result: FAIL

Output:

../../unit/test-eapol.c: In function 'pkcs8_precheck':
../../unit/test-eapol.c:3926:21: error: storage size of 's' isn't known
 3926 |         struct stat s;
      |                     ^
../../unit/test-eapol.c:3930:13: warning: implicit declaration of function 'stat' [-Wimplicit-function-declaration]
 3930 |         if (stat ("/sys/module/pkcs8_key_parser", &s) != 0)
      |             ^~~~
../../unit/test-eapol.c:3933:14: warning: implicit declaration of function 'S_ISDIR'; did you mean 'EISDIR'? [-Wimplicit-function-declaration]
 3933 |         if (!S_ISDIR (s.st_mode))
      |              ^~~~~~~
      |              EISDIR
../../unit/test-eapol.c:3926:21: warning: unused variable 's' [-Wunused-variable]
 3926 |         struct stat s;
      |                     ^
make[4]: *** [Makefile:2663: unit/test-eapol.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:3162: check-TESTS] Error 2
make[2]: *** [Makefile:3540: check-am] Error 2
make[1]: *** [Makefile:3542: check] Error 2
make: *** [Makefile:3461: distcheck] Error 1

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 10.05 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 0.00 seconds
Result: SKIP

Output:

makecheck was skipped

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 65.91 seconds
Result: FAIL

Output:

unit/test-eapol.c: In function 'pkcs8_precheck':
unit/test-eapol.c:3926:21: error: storage size of 's' isn't known
 3926 |         struct stat s;
      |                     ^
unit/test-eapol.c:3930:13: error: implicit declaration of function 'stat' [-Werror=implicit-function-declaration]
 3930 |         if (stat ("/sys/module/pkcs8_key_parser", &s) != 0)
      |             ^~~~
unit/test-eapol.c:3933:14: error: implicit declaration of function 'S_ISDIR'; did you mean 'EISDIR'? [-Werror=implicit-function-declaration]
 3933 |         if (!S_ISDIR (s.st_mode))
      |              ^~~~~~~
      |              EISDIR
unit/test-eapol.c:3926:21: error: unused variable 's' [-Werror=unused-variable]
 3926 |         struct stat s;
      |                     ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:2663: unit/test-eapol.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1800: all] Error 2

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.39 seconds
Result: PASS

@IWDTestBot
Copy link
Copy Markdown
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.44 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.43 seconds
Result: PASS

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 28.66 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 31.56 seconds
Result: FAIL

Output:

../../unit/test-eapol.c: In function ‘pkcs8_precheck’:
../../unit/test-eapol.c:3926:21: error: storage size of ‘s’ isn’t known
 3926 |         struct stat s;
      |                     ^
../../unit/test-eapol.c:3930:13: warning: implicit declaration of function ‘stat’; did you mean ‘strcat’? [-Wimplicit-function-declaration]
 3930 |         if (stat ("/sys/module/pkcs8_key_parser", &s) != 0)
      |             ^~~~
      |             strcat
../../unit/test-eapol.c:3933:14: warning: implicit declaration of function ‘S_ISDIR’; did you mean ‘EISDIR’? [-Wimplicit-function-declaration]
 3933 |         if (!S_ISDIR (s.st_mode))
      |              ^~~~~~~
      |              EISDIR
../../unit/test-eapol.c:3926:21: warning: unused variable ‘s’ [-Wunused-variable]
 3926 |         struct stat s;
      |                     ^
make[4]: *** [Makefile:2662: unit/test-eapol.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:3161: check-TESTS] Error 2
make[2]: *** [Makefile:3539: check-am] Error 2
make[1]: *** [Makefile:3541: check] Error 2
make: *** [Makefile:3460: distcheck] Error 1

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 20.76 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 0.00 seconds
Result: SKIP

Output:

makecheck was skipped

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 94.91 seconds
Result: FAIL

Output:

unit/test-eapol.c: In function ‘pkcs8_precheck’:
unit/test-eapol.c:3926:21: error: storage size of ‘s’ isn’t known
 3926 |         struct stat s;
      |                     ^
unit/test-eapol.c:3930:13: error: implicit declaration of function ‘stat’; did you mean ‘strcat’? [-Werror=implicit-function-declaration]
 3930 |         if (stat ("/sys/module/pkcs8_key_parser", &s) != 0)
      |             ^~~~
      |             strcat
unit/test-eapol.c:3933:14: error: implicit declaration of function ‘S_ISDIR’; did you mean ‘EISDIR’? [-Werror=implicit-function-declaration]
 3933 |         if (!S_ISDIR (s.st_mode))
      |              ^~~~~~~
      |              EISDIR
unit/test-eapol.c:3926:21: error: unused variable ‘s’ [-Werror=unused-variable]
 3926 |         struct stat s;
      |                     ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:2662: unit/test-eapol.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1799: all] Error 2

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.45 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 0.00 seconds
Result: SKIP

Output:

testrunner was skipped

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 98.47 seconds
Result: FAIL

Output:

unit/test-eapol.c:3926:14: error: variable has incomplete type 'struct stat'
        struct stat s;
                    ^
unit/test-eapol.c:3926:9: note: forward declaration of 'struct stat'
        struct stat s;
               ^
unit/test-eapol.c:3930:6: error: implicit declaration of function 'stat' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        if (stat ("/sys/module/pkcs8_key_parser", &s) != 0)
            ^
unit/test-eapol.c:3933:7: error: implicit declaration of function 'S_ISDIR' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        if (!S_ISDIR (s.st_mode))
             ^
3 errors generated.
make[1]: *** [Makefile:2662: unit/test-eapol.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1799: all] Error 2

@IWDTestBot IWDTestBot closed this Feb 19, 2026
@IWDTestBot IWDTestBot deleted the 1055469 branch February 19, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants