[PW_SID:1063808] [v3,1/4] station: check return of handshake_state_set_pmksa#492
[PW_SID:1063808] [v3,1/4] station: check return of handshake_state_set_pmksa#492IWDTestBot wants to merge 14 commits intoworkflowfrom
Conversation
This is taken care of by the individual cache items and if none exist, tar fails.
If this fails num_pmkids and pmkids would get set, but to an uninitialized buffer. This would then fail to build the handshake object later when copying the PMKID.
This makes adding roaming tests easier if they don't strictly conform to the existing test structure. By adding connect/roam helpers future tests will have a bit more control on whats being tested.
This test exposes a bug where if a PMKSA already exists for a BSS that we are roaming to IWD crashes due to a missing check in station.c
When pulling the pmksa out of the handshake object (to cache) we
also need to clear the expiration within the handshake itself. This
will prevent future attempts of setting the PMKSA into the handshake
due to the logic in handshake_state_set_pmksa():
/* checks for both expiration || pmksa being set */
if (s->expiration)
return false;
|
Fetch PR Prep - Setup ELL Make Distcheck Build - Configure Make Check Make Check w/Valgrind Incremental Build with patches |
|
Fetch PR GitLint Prep - Setup ELL Make Distcheck Build - Configure Make Check Make Check w/Valgrind Incremental Build with patches Autotest Runner Output: Clang Build |
github-actions
bot
force-pushed
the
workflow
branch
3 times, most recently
from
7d4e7ec to
c723eef
Compare
2 participants
If this fails num_pmkids and pmkids would get set, but to an
uninitialized buffer. This would then fail to build the handshake
object later when copying the PMKID.
src/station.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)