Update to dotnet-9, modernize ependencies: AngularJS-1.8.3, gulp, others #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rable. TitleNavBarLinkTarget: make title link to point to custom target
…rable. TitleNavBarLinkTarget: make title link to point to custom target
…, just patching neccessary files
rc.2 is failing miserably with impossible RCL error (dotnet/aspnetcore#42629) and requirement of some additional package reference to fix. Crazy but rc.1 works. Tests still failing on Inkball SignalR. Weird.
…ptions/options.JsonSerializerOptions.TypeInfoResolverChain combo
gulp ESM modules migration and rework fixing the JS code after eslint validation preparation for further enhancing
Updated all projects to target .NET 9.0, upgrading from .NET Core 3.1. Replaced IdentityServer4 with Duende IdentityServer due to IdentityServer4's end-of-life. Updated package references, namespaces, and related code to reflect the migration.
bump: Duende.IdentityServer in some not used project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the project from .NET Core 3.1 to .NET 9.0 and migrates authentication from IdentityServer4 to Duende IdentityServer. It also modernizes the GitHub Actions workflows and improves API response serialization and error handling. The most important changes are grouped below by theme.
Framework and Dependency Upgrades:
.csprojfiles to targetnet9.0instead ofnetcoreapp3.1. This includesHosts.CookieAuthentication.csproj,Hosts.IdentityServerAuthentication.csproj,Hosts.LosthostAuthentication.csproj, andHosts.Shared.csproj. [1] [2] [3] [4]IdentityServer4package withDuende.IdentityServer(version 7.4.4) inHosts.IdentityServerAuthentication.csproj, and updated related namespaces in controllers and startup files. [1] [2] [3]GitHub Actions Modernization:
actions/checkout@v4andactions/setup-dotnet@v4, and upgraded CodeQL actions to version 3. Also updated the .NET version in the workflow to9.0.x. [1] [2] [3] [4] [5]API Serialization and Response Improvements:
JsonSerializers.csfor various API models, improving performance and consistency in API responses.AnonymousCreatedUser,AnonymousCreatedRole, etc.) for user and role creation endpoints, and to use custom result types likeMetaResultfor metadata responses. [1] [2] [3] [4]Error Handling Enhancements:
?.Errors.Clear()) to avoid null reference exceptions in controllers. [1] [2] [3] [4] [5] [6]Miscellaneous API Improvements:
PageControllerto use the new context-based serializer and included additional parameters (TitleNavBarLinkTarget,LoginPath,LogoutPath) in the page model.These changes collectively modernize the codebase, improve maintainability, and enhance API usability and reliability.