Skip to content

Feature/chars reload and edit#158

Open
eduardorm-dev wants to merge 4 commits intoIllarion-eV:developfrom
eduardorm-dev:feature/chars-reload-and-edit
Open

Feature/chars reload and edit#158
eduardorm-dev wants to merge 4 commits intoIllarion-eV:developfrom
eduardorm-dev:feature/chars-reload-and-edit

Conversation

@eduardorm-dev
Copy link

@eduardorm-dev eduardorm-dev force-pushed the feature/chars-reload-and-edit branch from 5d71d48 to 3878501 Compare March 18, 2026 16:20
@voidowl-rl
Copy link
Contributor

Thanks for your PR.

Most of the code looks fine to me, but please avoid using java.awt.
For opening urls use Gdx.net.openURI instead.

@eduardorm-dev
Copy link
Author

eduardorm-dev commented Mar 18, 2026

@voidowl-rl thanks for the feedback. Now, I cannot find any clear reference to the method you were referring to. Could you provide some references?

Also, just to let you know, the project already uses java.awt several times, and one time it is used to open a link in the same method. Should we consider having a task for replacing those?

@voidowl-rl
Copy link
Contributor

voidowl-rl commented Mar 19, 2026

@eduardorm-dev
The LibGDX documentation is sadly not a very good one:
https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/Net.java#L397
https://libgdx.com/wiki/networking

I am aware that awt is already used, but it creates problems on mac therefore reducing its usage (on mac) instead of increasing it is favorable + openURI should work probably work on more devices.

@eduardorm-dev
Copy link
Author

@voidowl-rl I see, well, I investigated and performed the changes as you said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants