-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/sklearnex and remove faiss #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6a30340
Remove FAISS backend
NetZissou 868fb21
Auto-enable `scikit-learn-intelex` for CPU `sklearn` accel
NetZissou 788ec60
Added footnote for `sklearn-intelex` in README & BACKEND_PIPELINE
NetZissou 133e9bc
fix for optional extension install only on os that can use it
egrace479 3d6e63b
Apply footnote format changes
NetZissou a021cc8
Add CI Matrix to test install & import on OS + Py Matrix
NetZissou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: install + import | ||
|
|
||
| # CI matrix: verify the package installs cleanly and core modules | ||
| # import on every supported (OS, Python) pair, per pkg pyproject.toml's | ||
| # requires-python = ">=3.10,<3.14". | ||
| on: | ||
| pull_request: | ||
| workflow_dispatch: # allow manual reruns from the Actions tab | ||
|
|
||
| jobs: | ||
| install-and-import: | ||
| name: ${{ matrix.os }} / py${{ matrix.python-version }} | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| # Don't abort the whole matrix on a single failure so we can see all platforms. | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| python-version: ['3.10', '3.11', '3.12', '3.13'] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| # uv is our package manager of record, mirrors what users do locally. | ||
| - uses: astral-sh/setup-uv@v6 | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| # CPU-only install. gpu-cu12 / gpu-cu13 extras are skipped on CI runners | ||
| # (no NVIDIA hardware, CUDA wheels are large and slow to resolve). | ||
| - name: Install package | ||
| run: uv pip install --system -e . | ||
|
|
||
| # Smoke-test that the modules that get patched or accelerated import | ||
| # cleanly, and that both Streamlit app entry points are importable. | ||
| - name: Import smoke test | ||
| run: | | ||
| python -c "import shared.utils.clustering" | ||
| python -c "import apps.precalculated.app" | ||
| python -c "import apps.embed_explore.app" | ||
|
|
||
| # On x86_64 / AMD64 sklearnex must install (the platform marker in | ||
| # pyproject.toml ensures it). On macos-latest (arm64) it must NOT | ||
| # install, which is the whole point of the marker. | ||
| - name: Verify sklearnex matches platform marker | ||
| shell: python | ||
| run: | | ||
| import platform | ||
| import importlib.util | ||
| on_x86 = platform.machine() in ('x86_64', 'AMD64') | ||
| present = importlib.util.find_spec('sklearnex') is not None | ||
| if on_x86: | ||
| assert present, 'sklearnex should be installed on x86_64/AMD64' | ||
| import sklearnex | ||
| print(f'sklearnex {sklearnex.__version__} present on {platform.machine()}') | ||
| else: | ||
| assert not present, f'sklearnex must not install on {platform.machine()}' | ||
| print(f'sklearnex correctly absent on {platform.machine()}') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.