Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements an experimental obfuscation engine with enhanced biome support. Key changes include:
- Updates across multiple NmsManager implementations to correctly calculate the maximum number of bits needed for biome data.
- Addition of a new maxBitsPerBiome field and supporting API methods in the abstract NMS manager and API interface.
- A minor refactor in the world configuration interface, renaming shouldObfuscate to shouldProcessBlock.
Reviewed Changes
Copilot reviewed 51 out of 52 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| orebfuscator-plugin/src/main/java/net/imprex/orebfuscator/Orebfuscator.java | Added a comment regarding GZIPOutputStream, potentially for future use. |
| Various orebfuscator-nms/v*/NmsManager.java | Updated biome registry calls and adjusted constructor parameters for different Minecraft versions. |
| orebfuscator-nms-api/src/main/java/net/imprex/orebfuscator/nms/AbstractNmsManager.java | Added support for maxBitsPerBiome along with a new getter method. |
| orebfuscator-nms-api/src/main/java/net/imprex/orebfuscator/OrebfuscatorNms.java | Added a new getter for maxBitsPerBiome and updated the version string logic. |
| orebfuscator-common/src/main/java/net/imprex/orebfuscator/config/WorldConfigBundle.java | Renamed shouldObfuscate to shouldProcessBlock to better represent its purpose. |
Files not reviewed (1)
- orebfuscator-plugin/pom.xml: Language not supported
Comments suppressed due to low confidence (1)
orebfuscator-nms/orebfuscator-nms-api/src/main/java/net/imprex/orebfuscator/OrebfuscatorNms.java:29
- Clarify the rationale for excluding Paper servers from appending '_mojang' to the version string. If this exclusion is intentional, a brief comment explaining the reason would be helpful.
if (ServerVersion.isMojangMapped() && !ServerVersion.isPaper()) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of Changes