clang-format: Update to 16

[FintasticMan]

As discussed in #2127.
I've also updated the clang-format options to be compatible, and sorted the options.

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	374512B	-16B
data	948B	0B
bss	63488B	0B

[FintasticMan]

Sorry for the force push spam 😅. GitHub doesn't have an easy way to test CI locally, so I just did it in this PR. The failing clang-tidy test is because the infinitime-build container still uses Ubuntu 22.04. I think the reason we use the docker container in that check is to generate the compile_commands.json file that clang-tidy uses. Should I also update the docker container in this PR?

[mark9064]

Yeah may as well do it all in one go I think, it makes sense to do the upgrade atomically

[FintasticMan]

I've actually just thought that we don't necessarily need to update clang-tidy at the same time as clang-format, they don't interact at all. I might just revert the clang-tidy version bump and keep this PR to only updating clang-format.

[mark9064]

LGTM. It makes sense to keep the clang tooling at the same version to me though - tools get installed at the same time so the versions will be the same on real systems. In what scenario would you have clang-format from clang 16 installed but clang-tidy from 14 - it seems like we'd be using a very strange configuration here

[mark9064]

If clang-tidy isn't being updated, this should be undone right?

[FintasticMan]

Oh yeah, oops

[FintasticMan]

I agree that clang-tidy 14 with clang-format 16 is a bit of a strange setup, but I think that it's fine for the interim while I get clang-tidy 16 working.

[mark9064]

Oh, what's up with clang-tidy 16?

[mark9064]

Now I look at this, isn't clang-tidy just completely broken

[mark9064]

A working clang-tidy invocation: clang-tidy -p build $($ARM_NONE_EABI_TOOLCHAIN_PATH/bin/arm-none-eabi-g++ -E -Wp,-v -xc++ /dev/null 1>/dev/null 2>&1 | grep ' /' | sed 's/ \//\//' | xargs realpath | sed 's/^/-extra-arg=-isystem/' | tr '\n' ' ') src/main.cpp

[mark9064]

Should probably link an explanation for that: llvm/llvm-project#53468