ci: Normalise slash-containing github.head_ref values#2166
ci: Normalise slash-containing github.head_ref values#2166JF002 merged 1 commit intoInfiniTimeOrg:mainfrom
github.head_ref values#2166Conversation
|
Build size and comparison to main:
|
47c8d6c to
f0122ac
Compare
|
@mark9064 If you could run the workflow one more time - I was testing in zsh locally, not bash - tested in bash with the recent force-push, and it works locally. Should be fine now. |
|
No worries, CI development is the worst because testing in prod is basically the only way :P |
f0122ac to
8ac0c9b
Compare
|
One more time - then if that fails, I'll take a look either before or after working hours today. |
|
I think you might need to escape the forward slash in the substitution. I.e. |
|
On 15.11.2024 06:30, FintasticMan wrote:
I think you might need to escape the forward slash in the substitution. I.e. `${ref_name//\//-}`
The latest push should have the above implemented.
Best wishes,
--
Dom Rodriguez
|
8ac0c9b to
e7e4868
Compare
|
Ah, meant to push! Done now. |
e7e4868 to
73be6e5
Compare
FintasticMan
left a comment
There was a problem hiding this comment.
You've replaced github.head_ref with github.ref_name, meaning that the output is different.
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
73be6e5 to
f6ab516
Compare
|
Excellent! Once we get this landed, I'll rebase #2121 - and then we can merge that, too! |
|
Thanks for your contribution @shymega |
This fixes CI on #2121.