Open
Conversation
|
Build size and comparison to main:
|
Member
Author
|
Relevant discussion and testing in #2257 also |
mark9064
force-pushed
the
lvgl-placeholders
branch
from
36082c9 to
559e98b
Compare
Member
Author
|
Fixed placeholder in StopWatch. Honestly could do with refactoring more broadly to always render everything on load |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of the screens currently use placeholder values for labels etc.
Almost all of them can be eliminated by calling
Refresh()in the constructor and then correcting any alignment problems.The main advantage of this is that the screen content is up to date when the screen scrolls into view, rather than scrolling in with placeholder values and then loading the real content.
It also eliminates redundant data which is nice
One other pattern here is that the refresh task creation is moved to the end of the constructor, since it makes sense to start the refresh timer after a successful refresh rather than before it IMO