fix: set JDK 11 for JitPack builds#57
Open
Priveetee wants to merge 1 commit intoInfinityLoop1308:mainfrom
Open
fix: set JDK 11 for JitPack builds#57Priveetee wants to merge 1 commit intoInfinityLoop1308:mainfrom
Priveetee wants to merge 1 commit intoInfinityLoop1308:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
JitPack has been failing to build v4.7+ because it defaults to Java 8, but the extractor source uses `Set.of()`, `List.of()` and `Map.of()` which are Java 9+ APIs.
Here's what the build log actually says:
```
error: cannot find symbol
Set.of("google.", "m.google.", "www.google.")
symbol: method of(java.lang.String, ...)
location: interface java.util.Set
(9 errors total, all in YoutubeParsingHelper.java and YoutubeStreamLinkHandlerFactory.java)
```
Full log: https://jitpack.io/com/github/InfinityLoop1308/PipePipeExtractor/af78695668185ad6248ee4be7cb202538d9adb2a/build.log
Adding a
jitpack.ymlwithjdk: openjdk11tells JitPack to use Java 11 instead. No source changes,sourceCompatibilitystays at 1.8.Have a great day !