fix(release): revert build/smoke/publish split#224
Closed
Conversation
…1.26.2) The publish step in PR #222 used `--skip=build,validate,before` to reuse dist/ from a prior build step, but `--skip=build` was only added in goreleaser v2.x. v1.26.2-pro (pinned in this workflow) errors with "--skip=build is not allowed", failing the publish phase before any linux/.deb/.rpm/.apk artifacts reach the release. v0.43.83 ended up with only darwin+windows artifacts as a result. Revert to the pre-PR-222 single-step goreleaser invocation that worked. The smoke-test gate goes with it; portability regressions can be guarded post-publish or via a dry-run check instead.
|
💬 Discussion in Slack: #pr-review-cli-224-fix-release-revert-build-smoke-publish-split Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📣
--skip=build(used in PR #222's publish step) isn't valid in goreleaser-pro v1.26.2 — only added in v2.x. Publish step crashed at startup, so v0.43.83 shipped with only darwin+windows artifacts and no linux. Reverts the workflow to the pre-PR-222 single-step pattern.Type ✨
Tests 🛠️
Manual: cut a fresh release tag and confirm linux/.deb/.rpm/.apk artifacts ship alongside darwin+windows.