Skip to content

Follow up sanity fixes for editor maps, geocoding, and Discovery#511

Merged
leopiccionia merged 7 commits intoInfoAmazonia:codex/plugin-sanity-trackfrom
bwstefano:codex/baseline-followup-fixes
Apr 9, 2026
Merged

Follow up sanity fixes for editor maps, geocoding, and Discovery#511
leopiccionia merged 7 commits intoInfoAmazonia:codex/plugin-sanity-trackfrom
bwstefano:codex/baseline-followup-fixes

Conversation

@bwstefano
Copy link
Copy Markdown
Member

Summary

This follow-up branch closes the baseline issues that were left out of the main sanity track and packages the work into four areas:

1. Editor sidebar and map runtime follow-ups

  • keep the map, layer, and storymap editors on the Document sidebar instead of bouncing back to Block on selection
  • load the map runtime CSS in the block-editor iframe and related sidebar contexts so the Mapbox GL missing-CSS warning stops appearing in the editor
  • normalize the hidden and expanded Storymap slides settings panel widths

2. Post geocoding reliability

  • stabilize the geocoding field state after selecting an address, dragging a marker, canceling, saving, and reopening
  • keep the current address visible and actionable so new and existing points can be saved after drag or search updates
  • add an accent-insensitive fallback for address search so queries such as São Paulo, Belém, and Amapá work without forcing users to strip diacritics manually

3. Discovery markers, hover sync, sharing, and filters

  • switch Discovery GeoJSON features to stable per-point IDs while preserving the story/post ID in feature properties
  • keep marker, cluster, View in map, and card hover states in sync across multi-point stories and clustered results
  • scroll the stories list to the hovered marker or cluster and reflect list hover back onto markers or clusters in the map
  • increase the initial Discovery fetch window so more geolocated posts appear before filters are applied
  • replace Twitter and Facebook sharing with X and WhatsApp
  • include active story filters and selected layers in shared Discovery URLs and restore that state when opening the shared link
  • fix the tag-reset flow so removing a selected tag returns Discovery to the default result set
  • restore normal layer application in Discovery after the shared-layer initialization changes

4. Documentation close-out

  • remove the resolved baseline follow-ups from the upgrade report and smoke checklist
  • close the stale override-governance note
  • reclassify react-leaflet 5, PHPCS 4, and wp-cli PHP 8.5 noise as external monitoring paths instead of pending product bugs

Notes

  • no REST or post-meta contract changes are introduced in the Discovery work; only the internal feature ID strategy changes
  • this branch is intended to merge into codex/plugin-sanity-track

Testing

  • git diff --check
  • php scripts/check-php-compat.php
  • PATH="/opt/homebrew/opt/node@24/bin:$PATH" npm run test:unit
  • PATH="/opt/homebrew/opt/node@24/bin:$PATH" npm run build

bwstefano and others added 7 commits March 17, 2026 21:41
Pin map, layer, and storymap editors to the document sidebar so Gutenberg does not switch back to Block on selection.

Load the map runtime styles in the block-editor iframe and sidebar contexts, and patch Mapbox GL missing-CSS detection for cross-document editor rendering to avoid false warnings.

Normalize the storymap settings panel box sizing so the hidden and expanded panels keep the same visual width.

Co-authored-by: Codex <codex@openai.com>
Keep the geocoding combobox synced with the form state so selected and reverse-geocoded addresses remain visible during create and edit flows.

Use immutable checkpoints and functional state updates for point edits so drag, search, cancel, and save do not overwrite each other or leave the form buttons disabled.

Co-authored-by: Codex <codex@openai.com>
Retry post geocoding queries with an accent-stripped fallback when the original search returns no results, so locations like Sao Paulo, Belem, and Amapa remain discoverable when typed with diacritics.

Co-authored-by: Codex <codex@openai.com>
Use stable per-point feature IDs in Discovery so marker hover, cluster hover, and story card highlighting stay in sync even for stories with multiple points.

Scroll the stories list to the hovered marker or cluster target, and mirror list hover back to the map so individual pins and visible clusters get the expected highlighted state.

Include active story filters in shared Discovery URLs, restore them on load, switch social sharing to WhatsApp and X, and apply shared map layers immediately after restoring the selected layer queue.

Fix tag-filter clearing so removing a selected tag restores the unfiltered story list.

Co-authored-by: Codex <codex@openai.com>
Refresh the dependency upgrade report and smoke checklist after the editor,
geocoding, and Discovery follow-up fixes landed.

Reclassify react-leaflet 5, PHPCS 4, and wp-cli PHP 8.5 noise as
external monitoring paths instead of pending product bugs, and close
the stale override-governance note.

Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
@leopiccionia leopiccionia added this to the 3.1 milestone Mar 25, 2026
Comment thread src/js/src/shared/story-geojson.js
@leopiccionia leopiccionia merged commit ee44420 into InfoAmazonia:codex/plugin-sanity-track Apr 9, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants