fix: ppt开始放映时性能优化#510
Closed
Braydenccc wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates slideshow UI state changes to run safely on the UI thread and reduces duplicated state assignments.
Changes:
- Extracted UI-update logic into a local function and used
Dispatcher.CheckAccess()to decide direct vs dispatched execution. - Centralized
IsInPptPresentationModeassignment toisInSlideShowrather than setting it separately in each branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+147
to
+154
| if (_dispatcher.CheckAccess()) | ||
| { | ||
| UpdateSlideShowStatusOnUi(); | ||
| } | ||
| else | ||
| { | ||
| _dispatcher.Invoke(UpdateSlideShowStatusOnUi); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原来 UpdateSlideShowStatus(true, ...) 会把 IsInPptPresentationMode = true 放进 UI 调度队列里异步执行，但调用方马上会执行 CheckMainWindowVisibility()，因此在仅 PPT 模式下可能读到旧的 false，导致窗口不能立刻显示。