Skip to content

test(razorpaybilling): drive coverage 8.5% -> 100% #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mastermanas805 merged 1 commit into from
May 21, 2026
Merged

test(razorpaybilling): drive coverage 8.5% -> 100% #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/razorpaybilling/portal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,21 @@ type Portal struct {
Cfg *config.Config
}

// newClientForPortal is the factory used by Portal.client(). It is a
// package-level variable so unit tests in this package can install a
// version that points its BaseURL at an httptest.Server mock of the
// Razorpay API. Production code path is unchanged — the default is
// NewTimeoutClient verbatim.
var newClientForPortal = NewTimeoutClient

func (p *Portal) client() (*razorpay.Client, error) {
if p.Cfg.RazorpayKeyID == "" || p.Cfg.RazorpayKeySecret == "" {
return nil, fmt.Errorf("billing not configured")
}
// P0-2: 30s HTTP timeout via ApplyHTTPTimeout — never the bare SDK
// default (10s) which is below Razorpay's documented p99 for
// subscription create.
return NewTimeoutClient(p.Cfg.RazorpayKeyID, p.Cfg.RazorpayKeySecret), nil
return newClientForPortal(p.Cfg.RazorpayKeyID, p.Cfg.RazorpayKeySecret), nil
}

// SubscriptionID returns the Razorpay subscription id stored on the team (stripe_customer_id column).
Expand Down
Loading
Loading