fix(api): /healthz service=instanode-api + correct /livez vs /readyz comment (BUG-API-146/148/202/309)#184
Merged
mastermanas805 merged 1 commit intoMay 30, 2026
Conversation
…comment
BUG-API-146/148/309: /healthz.service emitted the legacy brand string
"instant.dev" — predates the rename to instanode.dev. Now emits
"instanode-api" so canaries that key on `service` to disambiguate
api / worker / provisioner /healthz stamps align with the runtime brand
and log-line correlation fields.
BUG-API-202: the /livez comment block claimed "the readiness signal lives
at /healthz" — actually wrong. /healthz is the shallow probe (commit_id +
migration stamp); /readyz is the deep readiness matrix wired to the k8s
readinessProbe (see handlers/readyz.go). Comment updated so future readers
don't get a wrong mental model.
Coverage block:
Symptom: /healthz.service = "instant.dev" (legacy brand)
Enumeration: rg -F '"instant.dev"' --type go
Sites found: 4 (router.go emit + healthz_test.go fixture + healthz_test.go assert + e2e_test.go assert)
Sites touched: 4 (all 4 — the remaining matches are inline comments
and unrelated DeployDomain default in config_test.go)
Coverage test: TestHealthzShape pins service="instanode-api" + asserts
legacy "instant.dev" must not regress (require.NotEqual).
Live verified: pending merge + auto-deploy + curl /healthz | jq .service
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mastermanas805
deleted the
fix/api-brand-drift-and-router-comment-2026-05-30
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthz.servicefrominstant.dev(legacy brand) toinstanode-apiso canaries + log correlation align with the runtime brandinternal/router/router.go— /livez block claimed/healthzis the readiness signal, but the deep readiness matrix actually lives at/readyzRule-17 coverage block
/healthz.service = "instant.dev"(legacy brand)rg -F '"instant.dev"' --type gorouter.goemit,healthz_test.gofixture,healthz_test.goassert,e2e/e2e_test.goassertDeployDomaindefault inconfig_test.go— config field, intentional, out of scope)TestHealthzShapepinsservice="instanode-api"plus an explicitrequire.NotEqual(t, "instant.dev", got["service"])regression assertcurl https://api.instanode.dev/healthz | jq .serviceTest plan
go build ./...go vet ./...go test ./internal/router/... -short -count=1go test ./e2e/... -short -count=1curl https://api.instanode.dev/healthz | jq .servicereturns"instanode-api"and.commit_idmatches merge commit short SHA (rule 14)