ci(coverage): remove || true test-masking + align ci.yml triggers#22
Merged
Conversation
Per the audit at /tmp/ci-audit-2026-05-22.md, the coverage workflow's test step was suppressing failures with `|| true` while still uploading whatever partial coverage data accumulated. This made the workflow report green even when tests failed silently — exactly the bug class CLAUDE.md rule 12 calls out (shipped != verified). Fix: drop `|| true`. Move codecov upload to `if: always()` so coverage still uploads on test failures but the workflow conclusion now reflects actual test status. (For common only — also brings ci.yml branch trigger in line with the [master, main] convention used by every other repo.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|| truefrom thego teststep in.github/workflows/coverage.ymlso the coverage workflow conclusion reflects actual test status.codecov/codecov-action@v4upload toif: always()so partial coverage still uploads on test failure (we get the data without the false-green)..github/workflows/ci.ymlbranch triggers from[main]to[master, main]to match every other InstaNode-dev repo (common's default ismaster, so the prior config wasn't firing on push to default).Per audit at /tmp/ci-audit-2026-05-22.md and CLAUDE.md rule 12: shipped != verified.
Test plan
if: always()🤖 Generated with Claude Code