test(coverage/logctx): drive logctx to ≥95% (was 87.1%)#25
Merged
Conversation
Adds tests for the uncovered branches in common/logctx: - WithGroup on the wrapper handler (was 0% — entire function uncovered) now exercised via TestHandler_WithGroupPreservesService, which also asserts that service + commit_id continue to be injected on records emitted through a grouped child handler. - The `if ctx == nil` guards in WithTraceID / WithTID / WithTeamID (each 66.7% — only the happy path was hit) covered by TestKeys_WithSettersAcceptNilCtx, which passes an explicitly nil context to each setter and round-trips through the matching getter. Result: logctx coverage 87.1% → 100.0%. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
mastermanas805
added a commit
that referenced
this pull request
May 21, 2026
Caps the cross-repo 95% coverage push for `common`. After PRs #25-#30 landed for crypto/nats/plans/readiness/r2/logctx, the two remaining storage backends sat at 63.6% (dospaces) and 72.2% (s3). dospaces -> 100.0% via accessor + customerEndpointURL fallback coverage: all simple getters (MasterAccessKey, MasterSecretKey, Endpoint, PublicURL, Bucket, Region, UseTLS) plus the scheme-prefix and already-schemed endpoint branches inside customerEndpointURL(). s3 -> 97.2% via accessor + IssueTenantCredentials default-fallback + safeSessionName branch coverage: digits/dashes/underscores retained, RoleSessionName truncation at 56, customerEndpointURL passthrough for already-schemed endpoints, RevokeTenantCredentials no-op confirmation, and AssumeRole error propagation through IssueTenantCredentials. Total: 94.5% -> 98.0%. Every package now >=95%. Coverage block (rule 17): Symptom: common total 94.5% < 95% target; per-pkg dospaces/s3 below floor Enumeration: go tool cover -func | sort | grep "<100" Sites found: 2 (storageprovider/dospaces, storageprovider/s3) Sites touched: both Coverage test: TestRegistry_AllProvidersSatisfyContract + per-backend registry-walk tests already in place; new coverage files add accessor + edge-branch assertions. Live verified: go test ./... -short -coverprofile cov.out; total = 98.0% Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handler.WithGroup(was 0%) by asserting service + commit_id still inject under a named group.if ctx == nilguard inWithTraceID/WithTID/WithTeamID(each 66.7%) with a table test that round-trips through the matching getter.Test plan
go test ./logctx -coverprofile=/tmp/l-cov.outgo tool cover -func=/tmp/l-cov.outreports 100.0%go vet ./logctxcleanCo-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code