chore(oss-prep): replace dev-default secrets with CHANGE_ME, parametrize MONGO_ADMIN_URI#18
Merged
Merged
Conversation
…ize MONGO_ADMIN_URI Per /tmp/oss-plan-2026-05-21/OSS-01-secrets-audit.md + OSS-05-infra-split.md: - k8s/secrets.yaml: PLATFORM_DB_PASSWORD + CUSTOMER_DB_PASSWORD + MINIO_ROOT_USER + MINIO_ROOT_PASSWORD → CHANGE_ME (were 'instant'/'instant_cust'/'minioadmin'/'minioadmin123' — local-dev convenience defaults that operators MUST replace) - k8s/data/minio-secret.yaml: same MinIO defaults → CHANGE_ME, comment notes self-hosted MinIO is retired - k8s/provisioner/deployment.yaml: MONGO_ADMIN_URI inline value 'mongodb://root:root@...' → secretKeyRef pointing at mongodb-admin Secret (matches the pattern every other credential already uses) - k8s/data/mongodb.yaml: append mongodb-admin Secret stub (with CHANGE_ME placeholder) so the secretKeyRef has a target This unlocks the infra repo for OSS publication. Note: git history still contains the dev-default values — operator should run `git filter-repo` before publishing if history-clean is required. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per OSS-01-secrets-audit + OSS-05-infra-split. k8s/secrets.yaml: 4 dev-default strings → CHANGE_ME. k8s/data/minio-secret.yaml: same MinIO defaults → CHANGE_ME (note: in-cluster MinIO retired 2026-05-20). k8s/provisioner/deployment.yaml: inline mongodb://root:root@... → secretKeyRef. k8s/data/mongodb.yaml: append mongodb-admin Secret stub for the secretKeyRef target. Operator NOTE: git history still contains the dev-default values — run
git filter-repobefore publishing if history-clean required. DO NOT auto-apply — infra has no auto-deploy; operator mustkubectl applyafter reviewing.