test(queue): drive NATS provisioner backend to 96.8% coverage#23
Merged
Conversation
Add unit/integration tests for the provisioner NATS queue backend covering the isolated dedicated-pod provisioning ladder, legacy NodePort URL fallback, deprovision, every rollback branch, and the local shared-cluster path. Introduce interface seams (kubernetes.Interface on K8sBackend, configurable monitorPort on LocalBackend) so the fake clientset and an httptest server can be injected without a real kube-apiserver or NATS server. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provisioner/internal/backend/queue(NATS), raising statement coverage from 24% to 96.8% (≥95% target met).nats-serveris needed:K8sBackend.csis nowkubernetes.Interface(fake clientset injection, mirroringredis/k8s.go), andLocalBackend.monitorPortis configurable for httptest.Test plan
go build ./...cleango vet ./internal/backend/queuecleango test ./internal/backend/queue -coverprofile=cov.out -count=1 -p 1→ 96.8%🤖 Generated with Claude Code