test(jobs): backup + misc job files to ≥95% coverage#55
Merged
Conversation
Covers Work() error/success branches across the backup, restore, prober, geodb, team-deletion, and scheduler jobs via sqlmock, an httptest S3 stub, and the live docker pg/redis/mongo/nats/minio backends. Each listed job file is now ≥95% statement coverage (const/type-only files excepted). geodb.go: geoLite2DownloadURL is now a package var (was const) so the download→extract→rename happy path can be driven against an httptest server; production never reassigns it. Fixed a pre-existing assertion in TestPlatformDBBackup_DumpError_ DeletePartialObject: a dump error propagates through io.Pipe to the uploader, so the partial-object delete branch is unreachable today — the test now pins the real failure contract. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
worker/internal/jobsto ≥95% statement coverage.coverage_gaps_test.gocovers the previously-missed Work() error/success branches;backup_extra_test.go+coverage_misc_test.goconsolidate prior partial work.geodb.go:geoLite2DownloadURLis now a packagevar(wasconst) so the download→extract→rename happy path is testable against httptest; production never reassigns it.Coverage (statement-level, listed files)
backup_audit.go+audit_kinds.goare const/type-only (no statements).Test plan
make gategreen (build + vet +go test ./... -short)go test ./internal/jobs -count=1 -p 1passesTestPlatformDBBackup_DumpError_DeletePartialObject🤖 Generated with Claude Code