Skip to content

test(coverage): worker internal/jobs 89.3% → ≥95% #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mastermanas805 merged 1 commit into from
May 22, 2026
Merged

test(coverage): worker internal/jobs 89.3% → ≥95% #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions internal/jobs/custom_domain_reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,14 @@ func (w *CustomDomainReconciler) reconcileCertReady(ctx context.Context, d activ
return reconcileRecordedErr
}

// txtLookupFunc is the TXT-resolution seam. Defaults to the stdlib resolver;
// overridden in tests so the verification-match / miss / error arms can be
// exercised without real DNS.
var txtLookupFunc = func(ctx context.Context, name string) ([]string, error) {
resolver := &net.Resolver{}
return resolver.LookupTXT(ctx, name)
}

// lookupTXT runs a context-bound TXT lookup at "_instanode.<hostname>" and
// returns whether any record matches "instanode-verify-<token>". Trims
// surrounding quotes some resolvers leave on TXT contents — same logic the
Expand All @@ -324,8 +332,7 @@ func (w *CustomDomainReconciler) lookupTXT(parent context.Context, hostname, tok
lookupCtx, cancel := context.WithTimeout(parent, txtLookupTimeout)
defer cancel()

resolver := &net.Resolver{}
records, err := resolver.LookupTXT(lookupCtx, txtChallengePrefix+hostname)
records, err := txtLookupFunc(lookupCtx, txtChallengePrefix+hostname)
if err != nil {
return false, fmt.Errorf("TXT lookup for %s failed: %w", txtChallengePrefix+hostname, err)
}
Expand Down
Loading
Loading