Skip to content

Conversation

@dxoigmn
Copy link
Member

@dxoigmn dxoigmn commented Mar 24, 2023

What does this PR do?

Right now we use tuples to signify a list of Tensors. This PR changes this to a list. Not sure this even makes sense to integrate though. This makes a lot of sense now since I forgot that the tuple could contain dicts or Tensors. Our current type annotations don't make this clear and tuple(torch.Tensor) doesn't make sense as a type annotation because it's defining the type as a tuple with a single element that is a torch.Tensor. Instead we mean that the tuple can contain many torch.Tensors.

One thing that is missing, however, is that we don't have tests for tuple/list of Tensors.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn changed the base branch from main to adversary_as_lightningmodule March 24, 2023 18:23
@dxoigmn dxoigmn marked this pull request as ready for review March 27, 2023 15:49
@dxoigmn
Copy link
Member Author

dxoigmn commented Apr 14, 2023

Closing in favor of #134.

@dxoigmn dxoigmn closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant