Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Right now we use tuples to signify a list of Tensors. This PR changes this to a list.
Not sure this even makes sense to integrate though.This makes a lot of sense now since I forgot that the tuple could contain dicts or Tensors. Our current type annotations don't make this clear andtuple(torch.Tensor)doesn't make sense as a type annotation because it's defining the type as atuplewith a single element that is atorch.Tensor. Instead we mean that thetuplecan contain manytorch.Tensors.One thing that is missing, however, is that we don't have tests for tuple/list of Tensors.
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Before submitting
pre-commit run -acommand without errorsDid you have fun?
Make sure you had fun coding 🙃