Make SequentialDict return outputs from all modules as DotDict

[dxoigmn]

What does this PR do?

Right now SequentialDict only returns the output module. This requires hardcoding a module with that name and often makes configuration more verbose than necessary. This PR removes that requirement and simplifies configuration by returning all outputs in the form of a DotDict. This is a breaking change and also removes ReturnKwargs since it is unnecessary.

This PR depends upon the following:

• Allow LitModular.*_step_log to be a dictionary #168
• Let loss/preds/target output keys be configurable in LitModular #169
• Remove *_step_end from LitModular #170

Type of change

Please check all relevant options.

• Improvement (non-breaking)
• Bug fix (non-breaking)
• New feature (non-breaking)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

• pytest
• CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
• CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

• The title is self-explanatory and the description concisely explains the PR
• My PR does only one thing, instead of bundling different changes together
• I list all the breaking changes introduced by this pull request
• I have commented my code
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

[mzweilin]

It looks like there're merged changes in mart/models/modular.py.
I will review again after you merge main into this.

[dxoigmn]

It looks like there're merged changes in mart/models/modular.py. I will review again after you merge main into this.

Should be good to review.

[mzweilin]

LGTM.

Shall we just delete ReturnKwargs in mart.nn?

[dxoigmn]

Leave it for now because some modules still use it. Making everything tidier should be a different PR.