Remove star import from _mkl_service#178
Merged
Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
There was a problem hiding this comment.
Pull request overview
This PR refines the mkl public API surface by replacing from ._py_mkl_service import * with explicit imports, preventing internal helper modules imported by the Cython extension (e.g., numbers, warnings) from leaking into mkl’s namespace and dir(mkl) output.
Changes:
- Replace star import from
._py_mkl_servicewith an explicit symbol import list. - Add an explicit
__all__to define the intended public export set.
ndgrigorian
changed the title
_py_mkl_service_mkl_service
antonwolfy
approved these changes
Apr 12, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @ndgrigorian
Collaborator
|
The only changelog is left |
antonwolfy
reviewed
Apr 13, 2026
antonwolfy
approved these changes
Apr 13, 2026
antonwolfy
left a comment
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
No more comments from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a star import in the
__init__from_mkl_service. This star import polluted__dir__withnumbersandwarningsmodules which are imported in_py_mkl_service.pyx. Replacing with individual imports resolved this issue.