Finish screenshot-capture E2E: add a CI Playwright job that runs the real capture code (captureRegion + feedback hook path) on an oklch page, no auth/server needed, green in CI#1824
Merged
psdjungpulzze merged 1 commit intoJul 7, 2026
Conversation
…rowser Playwright job Finishes goal #426's E2E: the full-UI feedback/SPM capture E2E can't run in CI (needs prod SSO + a running dev server + seeded DB), so the oklch regression was never actually guarded. This adds a self-contained guard that DOES run in CI. - tests/e2e/capture-oklch.ci.spec.ts: esbuild-bundles the REAL captureRegion (src/hooks/use-selection-mode.ts — the SPM capture path; the feedback modal uses the same import("html2canvas-pro")) into Chromium and runs it against a page using the exact Tailwind-4 oklch() palette values the app emits, asserting a PNG File (no throw). Legacy html2canvas throws "unsupported color function oklch" here, so the test fails on a revert. Also asserts both capture entry points import html2canvas-pro, not legacy html2canvas. - playwright.config.ts: new auth-free `capture-ci` project (no setup dep, no storageState); the authed chromium/mobile-chrome projects testIgnore *.ci.spec.ts. - .github/workflows/ci.yml: new `e2e-capture` job — installs chromium and runs the capture-ci project. No DB / dev server / SSO secrets. The existing full-UI tests/e2e/feedback-screenshot-capture-oklch.spec.ts stays as-is for local/manual coverage. No app runtime or agent-tool change → no PM Agent config update needed. Claude-Session: https://claude.ai/code/session_01MGnX9Ez8XJE1E1nrsDFFSa
psdjungpulzze
deleted the
goal/finish-screenshot-capture-e2e-add-a-ci-playwright-job-that-r
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.