-
Notifications
You must be signed in to change notification settings - Fork 44
Fix: Integer Overflow & OOM #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update IccMpeXml.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes a bug where an integer literal 0 was incorrectly passed as a default value to icXmlAttrValue(), which expects a const char* (string pointer). Passing 0 would be interpreted as a null pointer instead of the string "0", potentially causing undefined behavior or incorrect parsing when the "Flags" attribute is missing from XML.
Changes:
- Fixed two instances in
CIccMpeXmlEmissionCLUT::ParseXml()andCIccMpeXmlReflectanceCLUT::ParseXml()whereatoi(icXmlAttrValue(pNode, "Flags", 0))incorrectly used integer0instead of string"0"as the default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
#493
Pull Request Checklist