Skip to content

Conversation

@xsscx
Copy link
Member

@xsscx xsscx commented Jan 19, 2026

#493

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

Update IccMpeXml.cpp
@xsscx xsscx self-assigned this Jan 19, 2026
Copilot AI review requested due to automatic review settings January 19, 2026 12:17
@xsscx xsscx added the PR Pull Request label Jan 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug where an integer literal 0 was incorrectly passed as a default value to icXmlAttrValue(), which expects a const char* (string pointer). Passing 0 would be interpreted as a null pointer instead of the string "0", potentially causing undefined behavior or incorrect parsing when the "Flags" attribute is missing from XML.

Changes:

  • Fixed two instances in CIccMpeXmlEmissionCLUT::ParseXml() and CIccMpeXmlReflectanceCLUT::ParseXml() where atoi(icXmlAttrValue(pNode, "Flags", 0)) incorrectly used integer 0 instead of string "0" as the default value

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@xsscx xsscx added Merge Ready Maintainer indicates Merge Ready Copilot Review Reviewed by Copilot labels Jan 19, 2026
@xsscx xsscx requested a review from ChrisCoxArt January 19, 2026 12:30
@xsscx xsscx changed the title Fix: Integer Overflow Fix: Integer Overflow & OOM Jan 19, 2026
@xsscx xsscx linked an issue Jan 19, 2026 that may be closed by this pull request
@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Merge Ready Maintainer indicates Merge Ready labels Jan 21, 2026
@xsscx xsscx merged commit c0609ec into master Jan 21, 2026
20 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 21, 2026
@xsscx xsscx deleted the cfl-mods branch January 21, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copilot Review Reviewed by Copilot Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Integer & OOM Issues

3 participants