Skip to content

Fix: Flags attribute in XML observer parsing #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsscx merged 1 commit into from
Jan 21, 2026
Merged

Fix: Flags attribute in XML observer parsing #498

xsscx merged 1 commit into from
Jan 21, 2026

Conversation

@xsscx
Copy link
Member

@xsscx xsscx commented Jan 19, 2026

#497

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@xsscx xsscx requested a review from ChrisCoxArt January 19, 2026 17:43
@xsscx xsscx self-assigned this Jan 19, 2026
@xsscx xsscx added PR Pull Request Merge Ready Maintainer indicates Merge Ready labels Jan 19, 2026
Copilot AI review requested due to automatic review settings January 19, 2026 17:43
@xsscx xsscx linked an issue Jan 19, 2026 that may be closed by this pull request
Fix: Flags attribute in XML observer parsing #497
Closed
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a type mismatch bug in XML parsing where integer 0 was incorrectly passed to icXmlAttrValue() instead of the string "0". The function expects a const char* for its default value parameter. The fix ensures proper default handling when the "Flags" attribute is missing from XML observer elements.

Changes:

  • Fixed type mismatch in CIccMpeXmlEmissionObserver::ParseXml by changing the default parameter from integer 0 to string "0"
  • Fixed type mismatch in CIccMpeXmlReflectanceObserver::ParseXml by changing the default parameter from integer 0 to string "0"

@xsscx
Fix: Flags attribute in XML observer parsing
6359c8b 
Fix: Flags attribute in XML observer parsing
@xsscx xsscx requested a review from Copilot January 19, 2026 17:50
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@xsscx xsscx added the Copilot Review Reviewed by Copilot label Jan 19, 2026
@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Merge Ready Maintainer indicates Merge Ready labels Jan 21, 2026
@xsscx xsscx merged commit 7d90091 into master Jan 21, 2026
28 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 21, 2026
@xsscx xsscx deleted the fix-tc-flags branch January 21, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ChrisCoxArt ChrisCoxArt ChrisCoxArt approved these changes

Assignees

@xsscx xsscx

Labels

Copilot Review Reviewed by Copilot Merged Merged PR Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix: Flags attribute in XML observer parsing

3 participants

@xsscx @ChrisCoxArt