Fix/whitelabel v2.3 compatibility#11
Open
cappuMUC wants to merge 2 commits into
Open
Conversation
- Pinia 3: changed defineStore({id, ...}) to defineStore(id, {…})
(single-object overload removed in Pinia 3)
- Use window.http.post() instead of window.axios.post()
(main app no longer exposes window.axios)
- Fixed ThemeSelector.vue: @heroicons/vue/solid -> @heroicons/vue/20/solid
- Updated vite.config.js for Vite 8 / rolldown external syntax
- Removed obsolete postcss.config.js, autoprefixer, postcss deps
- Added define config for process.env.NODE_ENV replacement
- Fixed trailing newlines in scss files
…ayload - Skip customer_portal_page_title in the company settings payload when it's null (not yet set by user) to avoid NOT NULL constraint failure on company_settings.value - Use correct response property logoRes.data.customerPortalLogoUrl instead of logoRes.data.url (the controller returns customerPortalLogoUrl)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a working solution to fix the incompatibility with version 2.3 mentioned in #8 . As this pull request is mostly AI generated and I'm not so deep into web development it may need a second look but from a first glimpse it looks not so wrong to me.
The fix relies on the axios module to be exposed by the main application which is no longer the case in 2.3 at the moment. An additional change (single line) in InvoiceShelf itself is also needed. This could also help for other modules which also rely on the global axios instance. If we decide to integrate the PR I could open a pull request there, too.