Skip to content

Conversation

@longsizhuo
Copy link
Member

本次更改需要回测主页投稿按钮;
新增每一页右上角的Edit Button

@vercel
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
involutionhell-github-io Ready Ready Preview Comment Sep 18, 2025 2:45pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an "Edit on GitHub" button to documentation pages and refactors GitHub-related functionality into a centralized utility module. The changes improve code maintainability by consolidating GitHub constants and URL generation logic while adding user-friendly editing capabilities.

  • Centralized GitHub utility functions in a dedicated module with proper URL encoding for Chinese characters
  • Added "Edit on GitHub" button component with Material Icons styling to documentation pages
  • Refactored existing contribution form to use the new utility functions

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/github.ts New utility module containing GitHub constants and URL generation functions
app/layout.tsx Added Google Material Icons font for the edit button
app/docs/[...slug]/page.tsx Integrated edit button into documentation page layout
app/components/EditOnGithub.tsx New reusable edit button component
app/components/Contribute.tsx Refactored to use centralized GitHub utility functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

aria-label="Edit on GitHub"
>
<span
aria-hidden
Copy link

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aria-hidden attribute should have a value. It should be aria-hidden="true" to properly hide the decorative icon from screen readers.

Suggested change
aria-hidden
aria-hidden="true"

Copilot uses AI. Check for mistakes.
@Crokily
Copy link
Contributor

Crokily commented Sep 17, 2025

check失败了
image
image
vercel的失败无法访问进去查看细节。

@longsizhuo longsizhuo merged commit 986e6a0 into main Sep 18, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this to Done in Frontend Sep 18, 2025
@longsizhuo longsizhuo deleted the editButton branch October 8, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants