fix: crash and stability fixes with shutdown timeouts#11
Open
Xytronix wants to merge 1 commit intoIroriPowered:masterfrom
Open
fix: crash and stability fixes with shutdown timeouts#11Xytronix wants to merge 1 commit intoIroriPowered:masterfrom
Xytronix wants to merge 1 commit intoIroriPowered:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds defensive guards and exception handling to prevent crashes and hangs caused by corrupt/stale data, race conditions, and thread-safety issues.
I prevented the restarts happening with watchdog on multiple worlds and player joins crashing the server during startup.
Related issues
Type of change
Implementation details
IllegalStateExceptioninupdate()world.execute()to avoid thread-safety crashesTransformComponentand empty archetypeshandleClientReadyto the world thread, compatibility prevention patch (optional)getSpawnTransform()onEntityAddedinMixinMarkerAddRemoveSystem.javafor load-time resilience; redirectsgetNpcReferences()to pre-filter by UUID, preventingArrayIndexOutOfBoundsExceptionwhen stale data causes a size mismatch in the vanilla copy loopMixinMarkerAddRemoveSystem.javain asyncremovePlayerCompletableFuture.join()inshutdown0to prevent indefinite blockingCompletableFuture.join()inonShutdownworld config saveChecklist
spotlessApplywhen necessary)