fix: replace per-block logging with summary and iterate by section skipping air in UnknownBlockCleaner#18
Open
Xytronix wants to merge 3 commits intoIroriPowered:masterfrom
Open
Conversation
…ipping air in UnknownBlockCleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I made
UnknownBlockCleanerchunk cleanup less noisy and more efficient.Instead of logging one warning per removed block, cleanup now aggregates removed unknown blocks by block ID and emits one summary log per chunk.
It also now prefers scanning only non-air sections by accessing
BlockChunk/BlockSection.This helps in the world ticking block after a player joins and turns this on in a modded world.
Type of change
Implementation details
BlockChunkvia cached reflective lookup.ChunkUtil.SIZEstride).null/isSolidAir()sections.BlockChunkcannot be resolved.Map<String, Integer>counters.Checklist
spotlessApplywhen necessary)