Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
os: [ubuntu-latest]
ruby-version:
- head
- '4.0'
- '3.4'
- '3.3'
- '3.2'
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# https://github.com/bbatsov/rubocop/tree/master/config

AllCops:
TargetRubyVersion: 3.4
TargetRubyVersion: 4.0
NewCops: enable

# General
Expand Down
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Below is a complete listing of changes for each revision of HighLine.

### 3.1.2 / 2025-01-05
* Fix Ruby software license URL in LICENSE file (@jeffwidman)
* PR #279 - Upgrades and adjustments for Ruby 3.4 release (@abinoam)
* PR #278 - Prevent ArgumentError for #col_count_calculate when items exceed 80 chars (@davidjkling, @justintsteele)

Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ group :code_quality do
gem "flog", require: false
gem "pronto", require: false, platform: :ruby
gem "pronto-flay", require: false, platform: :ruby
gem "path_expander", "1.1.1", require: false # Remove this lock when path_expander > 1.1.2 and flay > 2.13.3 is released.
gem "path_expander", require: false
# gem "pronto-poper", require: false, platform: :ruby
gem "pronto-reek", require: false, platform: :ruby
gem "pronto-rubocop", require: false, platform: :ruby
Expand Down
6 changes: 0 additions & 6 deletions TODO

This file was deleted.

1 change: 0 additions & 1 deletion doc/.cvsignore

This file was deleted.

4 changes: 2 additions & 2 deletions test/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM ruby
FROM ruby:latest

WORKDIR /highline


RUN bash -ec 'apt update; apt -y install cmake'

ADD Gemfile highline.gemspec .git* ./
ADD Gemfile Gemfile.lock highline.gemspec .git* ./
ADD lib/highline/version.rb ./lib/highline/version.rb
RUN bundle install

Expand Down
15 changes: 11 additions & 4 deletions test/test_string_extension.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,19 @@ def test_highline_string_still_raises_for_non_available_messages
end

def test_String_includes_StringExtension_when_receives_colorize_strings
@include_received = 0
caller = proc { @include_received += 1 }
::String.stub :include, caller do
include_received = 0
::String.singleton_class.define_method(:include) do |*modules|
include_received += 1
modules
end

begin
HighLine.colorize_strings
ensure
::String.singleton_class.remove_method(:include)
end
assert_equal 1, @include_received

assert_equal 1, include_received
end

def test_respond_to_dynamic_style_methods
Expand Down
Loading