Compare FitMethod enum value to correct string#46
Open
rvighne wants to merge 1 commit intoJaciBrunning:masterfrom
Open
Compare FitMethod enum value to correct string#46rvighne wants to merge 1 commit intoJaciBrunning:masterfrom
rvighne wants to merge 1 commit intoJaciBrunning:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the native JNI code compared the
FitMethodenum value with the strings "FIT_HERMITE_CUBIC" and "FIT_HERMITE_QUINTIC," however these should be "HERMITE_CUBIC" and "HERMITE_QUINTIC" respectively (to match the names in the Java source code). This caused a bug in which it's impossible to select the quintic method.I corrected this in the JNI code, not the Java code, so existing users of library don't need to make changes.