feat(markdown-validator): add skip logic and MD013 fallback #27
Conversation
Add two improvements to the markdown validator: 1. Skip Logic: Automatically skip validation for: - Home directory dotfiles/dotdirs (~/.config/, ~/.local/, ~/.claude/) - Any .claude directory at any level in any project - Prevents validation errors in system/config files 2. MD013 Fallback: Add guaranteed fallback config when plugin config unavailable: - Creates temporary inline config with MD013=160 - Ensures 160-character line limit is always enforced - Prevents fallback to markdownlint's 80-character default - Handles edge cases where CLAUDE_PLUGIN_ROOT is unset or config missing Version bumped to 1.1.0 with updated documentation. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to d5144e2 in 7 seconds. Click for details.
- Reviewed
105lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_8YySbWv50sBN6axi
You can customize 
Summary of ChangesHello @JacobPEvans, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the markdown validator plugin by introducing robust skip logic and a guaranteed fallback for line length enforcement. The changes aim to reduce false positive validation errors in system-related files and ensure consistent adherence to a 160-character line limit across all environments, thereby enhancing the plugin's reliability and user experience without compromising existing configurations. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Update code_block_line_length from 160 to 120 to keep code concise. Changes: - Temporary fallback config in validation script - Bundled plugin config file - Documentation example Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 78aa051 in 8 seconds. Click for details.
- Reviewed
48lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_Lwohplk4l1eQdWGe
You can customize
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces useful enhancements to the markdown validator, including skip logic for dotfiles and a robust fallback for the line-length rule. The changes are well-documented in the README. However, I found a high-severity bug in the temporary file cleanup logic that will lead to orphaned files on the system. My review includes a specific fix for this issue.
There was a problem hiding this comment.
Pull request overview
Enhances the markdown-validator Claude Code plugin to reduce unwanted validations and to enforce a consistent MD013 line-length rule even when configs are missing/unavailable.
Changes:
- Add early skip logic for home-directory dotfiles/dotdirs and any
.claudedirectories. - Add a 4th-tier markdownlint config fallback by generating a temporary inline config enforcing MD013=160.
- Update plugin documentation and bump plugin version to 1.1.0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
markdown-validator/scripts/validate-markdown.sh |
Adds skip rules and introduces a temp-config fallback for markdownlint-cli2 config resolution. |
markdown-validator/README.md |
Documents skip behavior and the 4-tier config resolution chain including the guaranteed fallback. |
markdown-validator/.claude-plugin/plugin.json |
Bumps plugin version from 1.0.0 to 1.1.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Implement automatic Nix flake updates when changes merge to main: - Add trigger workflow that sends repository_dispatch to nix repo - Uses generic upstream-repo-updated event type for scalability - Requires WORKFLOW_DISPATCH_PAT organization secret - Document setup instructions and reusable pattern in README This ensures downstream nix repository immediately pulls in plugin updates instead of waiting for daily scheduled updates. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 5b5eac3 in 8 seconds. Click for details.
- Reviewed
148lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_4vmhQwdZCtdNGJHa
You can customize
Update workflow and documentation to use the existing organization secret GH_PAT_WORKFLOW_DISPATCH instead of WORKFLOW_DISPATCH_PAT. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed e21caf9 in 8 seconds. Click for details.
- Reviewed
35lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_FOTU9vxtBtKxG404
You can customize
JacobPEvans
deleted the
feat/markdown-validator-skip-logic-md013-fallback
branch
1 participant
Summary
Enhances the markdown validator plugin with two critical improvements:
.claudedirectoriesChanges
1. Skip Logic for Dotfiles and .claude Directories
~/.config/,~/.local/,~/.claude/).claudedirectory at any level2. MD013 Fallback with Guaranteed 160-Character Limit
CLAUDE_PLUGIN_ROOTis unset or config is missing3. Documentation Updates
4. Version Bump
Test Plan
~/.config/test.md~/git/repo/.claude/test.mdImpact
🤖 Generated with Claude Code
Important
Enhances markdown validator with skip logic for dotfiles and
.claudedirectories, and a fallback for MD013 configuration..claudedirectories invalidate-markdown.sh.validate-markdown.sh.validate-markdown.sh.config/.markdownlint-cli2.yamlto setcode_block_line_lengthto 120.markdown-validator/README.md.plugin.json.This description was created by
for e21caf9. You can customize this summary. It will automatically update as commits are pushed.