Modularization and cleanup#41
Open
Jacoby6000 wants to merge 7 commits intomainfrom
Open
Conversation
|
Visit the preview URL for this PR (updated for commit 4824fac): https://polehammer-a740e--pr41-modularization-1sk98o44.web.app (expires Thu, 22 Jun 2023 19:00:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 13b24c1e1fbce843143b4a9fff97ac2e608dde1b |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| var i = 1; | ||
| this.headers.forEach(header => { | ||
| let range = this.ranges.get(header)!; |
There was a problem hiding this comment.
🚫 [tsc] <6133> reported by reviewdog 🐶
'range' is declared but its value is never read.
|
|
||
| cell.innerHTML = cellContent; | ||
| cell.className = "border"; | ||
| cell.style.backgroundColor = metricColor(data, unitStats.get(category)!); |
There was a problem hiding this comment.
🚫 [tsc] <2304> reported by reviewdog 🐶
Cannot find name 'unitStats'.
|
|
||
| cell.innerHTML = cellContent; | ||
| cell.className = "border"; | ||
| cell.style.backgroundColor = metricColor(data, unitStats.get(category)!); |
There was a problem hiding this comment.
🚫 [tsc] <2304> reported by reviewdog 🐶
Cannot find name 'category'.
| }); | ||
| table.appendChild(row); | ||
| }); | ||
| tableElem.appendChild(table); |
There was a problem hiding this comment.
🚫 [tsc] <2663> reported by reviewdog 🐶
Cannot find name 'tableElem'. Did you mean the instance member 'this.tableElem'?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start cleaning up the code