Merged
Conversation
…antly The notification style setting (Minimal/Detailed) existed in the UI and DataStore but the service hardcoded MINIMAL. Now the service reads the preference on startup and observes it as a Flow so changes apply immediately without waiting for the 30-second ticker. - Add NotificationStyle.fromPreference() to convert DataStore strings - Read preference in startForegroundWithNotification() and ticker - Add launchNotificationStyleObserver() for instant style switching - Use startForeground() for updates (more reliable than notify()) - Remove unused NotificationHelper.updateNotification() and its field - Add unit tests for fromPreference() Closes #14 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MINIMAL. Now the service reads the stored preference and reacts to changes instantly.NotificationStyle.fromPreference()to convert DataStore strings to the enum, with fallback toMINIMALfor unknown values.launchNotificationStyleObserver()coroutine that collects the preference Flow and immediately updates the notification when the user changes the style — no more waiting up to 30 seconds.NotificationHelper.updateNotification()method (replaced bystartForeground()calls for more reliable notification updates).Test plan
fromPreferenceconversion, case-insensitivity, unknown fallback)Closes #14