fix(extension): 修复插件任务删除和目录跳转问题#379
Open
techotaku39 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动概述
修复浏览器插件历史任务删除后又被 popup / sidepanel / 后端同步刷回的问题,并修复插件侧 Markdown 目录锚点跳转不稳定的问题。
为什么
用户在插件 popup / sidepanel 删除任务时遇到几个问题:
confirm(),如果用户勾选了“阻止此页面继续弹出对话框”,后续删除会无响应。做了什么
window.confirm()。/api/delete_task,同步清理服务端记录。upsertTask重新写回。测试方式
pnpm build(浏览器插件)通过pnpm typecheck(浏览器插件)通过pnpm exec eslint src/logic/api.ts src/logic/constants.ts src/logic/storage.ts src/popup/Popup.vue src/sidepanel/Sidepanel.vue src/components/MarkdownView.vue通过,无 error;剩余为项目既有 Vue 单行文本换行 warning回归风险
/api/delete_task能力;需要与后端同步部署。Checklist
fix/extension-delete-sync)develop;本 PR 依赖 feat(auth): 支持自托管访问鉴权与笔记同步 #378)type(scope): subject格式.env/ 大型二进制BillNote_extension/6 个文件)