fix(e2e): guard governance lifecycle tests for unconfigured persistence#108
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
The 'Select an experiment to view its governance state' and 'View transition history' scenarios timed out in CI because the NotConfiguredMessage locator used .empty-state but the Blazor page renders .info-message when IGovernancePersistenceBackplane is absent. This caused IsConfiguredAsync() to return true, then AssertCurrentStateVisibleAsync() and AssertTransitionHistoryVisibleAsync() waited 30 s for elements that are only rendered when state is loaded. - Add .info-message to the NotConfiguredMessage locator so IsConfiguredAsync() correctly detects the unconfigured state. - Guard ThenIShouldSeeTheCurrentGovernanceState and ThenIShouldSeeTheTransitionHistorySection with the same IsConfiguredAsync() check already used by ThenIShouldSeeAvailableTransitions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JerrettDavis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 80.81% 80.81%
=======================================
Files 264 264
Lines 10508 10508
Branches 1836 1836
=======================================
Hits 8492 8492
Misses 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Code Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Select an experiment to view its governance stateandView transition historyE2E scenarios timed out in CI with a 30sSystem.TimeoutExceptionwhile waiting for.current-state, [data-current-state], .lifecycle-stateto be visible.NotConfiguredMessagelocator used.empty-statebut the BlazorLifecycle.razorpage renders.info-messagewhenIGovernancePersistenceBackplaneis absent after an experiment is selected. This madeIsConfiguredAsync()returntrue, so steps proceeded to assert on elements that only render when governance state actually loads..info-messagetoGovernanceLifecyclePage.NotConfiguredMessagelocator.ThenIShouldSeeTheCurrentGovernanceStateandThenIShouldSeeTheTransitionHistorySectionwithIsConfiguredAsync()check (same pattern already used byThenIShouldSeeAvailableTransitions).Test plan
🤖 Generated with Claude Code